Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Jun 11, 2025

Important

Standardizes API request timeouts to 5 seconds across the Langfuse Python SDK, introducing LANGFUSE_TIMEOUT for configuration.

  • Behavior:
    • Standardizes API request timeouts to 5 seconds in langfuse/_client/client.py for client, media resolution, and prompt fetching.
    • Introduces LANGFUSE_TIMEOUT environment variable in langfuse/_client/environment_variables.py for timeout configuration.
  • Tests:
    • Updates test_get_expired_prompt_when_failing_fetch in tests/test_prompt.py to reflect new timeout behavior.
  • Misc:
    • Reduced timeout values could impact operations on slower networks.

This description was created by Ellipsis for a49fc96. You can customize this summary. It will automatically update as commits are pushed.


Greptile Summary

Disclaimer: Experimental PR review

Standardizes API request timeouts to 5 seconds across the Langfuse Python SDK, introducing LANGFUSE_TIMEOUT environment variable for configuration.

  • Modified langfuse/_client/environment_variables.py to add new LANGFUSE_TIMEOUT environment variable
  • Changed default timeouts in langfuse/_client/client.py from 10-30s to 5s for client, media resolution, and prompt fetching
  • ⚠️ Reduced timeout values could impact operations on slower networks
  • Consider testing with slower network conditions to ensure 5s is sufficient for typical use cases

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp enabled auto-merge (squash) June 11, 2025 09:30
@hassiebp hassiebp merged commit ede6454 into main Jun 11, 2025
10 checks passed
@hassiebp hassiebp deleted the fix-timeouts branch June 11, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants