Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Jun 16, 2025

Important

Fix _url_encode method in client.py to escape slashes, ensuring correct URL encoding for prompts in folders.

  • Behavior:
    • Fix _url_encode method in client.py to escape slashes by setting safe="" in urllib.parse.quote.
    • Ensures correct URL encoding for prompts in prompt folders.

This description was created by Ellipsis for f8772e3. You can customize this summary. It will automatically update as commits are pushed.

Greptile Summary

Disclaimer: Experimental PR review

Fixed URL encoding in the Python client to properly handle slashes by modifying _url_encode method in langfuse/_client/client.py to use urllib.parse.quote() with safe="" parameter.

  • Added proper slash encoding in URLs by removing them from the safe characters list, essential for prompts stored in nested folders
  • This is a low-risk change that improves URL handling reliability without impacting core functionality

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

hassiebp and others added 2 commits June 16, 2025 13:35
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@hassiebp hassiebp enabled auto-merge (squash) June 16, 2025 11:53
@hassiebp hassiebp merged commit eb5a1ba into main Jun 16, 2025
10 checks passed
@hassiebp hassiebp deleted the chore-url-encoding-slashes branch June 16, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants