Skip to content

fix(resource-manager): do not register processor if tracing disabled #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 4 commits into from
Jun 16, 2025
Merged

fix(resource-manager): do not register processor if tracing disabled #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae7ca32
fix(resource-manager): do not register processor if tracing disabled
hassiebp Jun 16, 2025
e3553af
Update langfuse/_client/resource_manager.py
hassiebp Jun 16, 2025
21f9db7
Merge branch 'main' into hassieb/lfe-5303-disable-processor-tracing-d…
hassiebp Jun 16, 2025
4817334
Merge branch 'main' into hassieb/lfe-5303-disable-processor-tracing-d…
hassiebp Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions langfuse/_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ def __init__(
media_upload_thread_count=media_upload_thread_count,
sample_rate=sample_rate,
mask=mask,
tracing_enabled=self._tracing_enabled,
)
self._mask = self._resources.mask

Expand Down
40 changes: 22 additions & 18 deletions langfuse/_client/resource_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def __new__(
media_upload_thread_count: Optional[int] = None,
sample_rate: Optional[float] = None,
mask: Optional[MaskFunction] = None,
tracing_enabled: Optional[bool] = None,
) -> "LangfuseResourceManager":
if public_key in cls._instances:
return cls._instances[public_key]
Expand All @@ -113,6 +114,7 @@ def __new__(
media_upload_thread_count=media_upload_thread_count,
sample_rate=sample_rate,
mask=mask,
tracing_enabled=tracing_enabled if tracing_enabled is not None else True,
)

cls._instances[public_key] = instance
Expand All @@ -134,33 +136,35 @@ def _initialize_instance(
httpx_client: Optional[httpx.Client] = None,
sample_rate: Optional[float] = None,
mask: Optional[MaskFunction] = None,
tracing_enabled: bool = True,
):
self.public_key = public_key
self.secret_key = secret_key
self.host = host
self.mask = mask

# OTEL Tracer
tracer_provider = _init_tracer_provider(
environment=environment, release=release, sample_rate=sample_rate
)
if tracing_enabled:
tracer_provider = _init_tracer_provider(
environment=environment, release=release, sample_rate=sample_rate
)

langfuse_processor = LangfuseSpanProcessor(
public_key=self.public_key,
secret_key=secret_key,
host=host,
timeout=timeout,
flush_at=flush_at,
flush_interval=flush_interval,
)
tracer_provider.add_span_processor(langfuse_processor)
langfuse_processor = LangfuseSpanProcessor(
public_key=self.public_key,
secret_key=secret_key,
host=host,
timeout=timeout,
flush_at=flush_at,
flush_interval=flush_interval,
)
tracer_provider.add_span_processor(langfuse_processor)

tracer_provider = cast(TracerProvider, otel_trace_api.get_tracer_provider())
self._otel_tracer = tracer_provider.get_tracer(
LANGFUSE_TRACER_NAME,
langfuse_version,
attributes={"public_key": self.public_key},
)
tracer_provider = cast(TracerProvider, otel_trace_api.get_tracer_provider())
self._otel_tracer = tracer_provider.get_tracer(
LANGFUSE_TRACER_NAME,
langfuse_version,
attributes={"public_key": self.public_key},
)

# API Clients

Expand Down
Loading