fix(client): correctly scope client in multiproject setups #1218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes
get_client()to correctly includesecret_keyandhostfor clients in multi-project setups, preventing misconfiguration.get_client(), ensure returnedLangfuseclient includessecret_keyandhostfrom existing instance.public_keyis provided in a multi-project setup, indicating tracing is disabled to prevent data leakage.This description was created by
for b21e2fc. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Fixes critical client initialization issues in multi-project setups by ensuring proper propagation of host and secret_key parameters when creating new Langfuse client instances via
get_client().langfuse/_client/get_client.pyfor consistent client configuration