Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions langfuse/_client/get_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def get_client(*, public_key: Optional[str] = None) -> Langfuse:
public_key=instance.public_key,
secret_key=instance.secret_key,
host=instance.host,
tracing_enabled=instance.tracing_enabled,
)

else:
Expand Down Expand Up @@ -94,4 +95,5 @@ def get_client(*, public_key: Optional[str] = None) -> Langfuse:
public_key=public_key,
secret_key=instance.secret_key,
host=instance.host,
tracing_enabled=instance.tracing_enabled,
)
5 changes: 4 additions & 1 deletion langfuse/_client/resource_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ def __new__(
media_upload_thread_count=media_upload_thread_count,
sample_rate=sample_rate,
mask=mask,
tracing_enabled=tracing_enabled if tracing_enabled is not None else True,
tracing_enabled=tracing_enabled
if tracing_enabled is not None
else True,
)

cls._instances[public_key] = instance
Expand All @@ -140,6 +142,7 @@ def _initialize_instance(
):
self.public_key = public_key
self.secret_key = secret_key
self.tracing_enabled = tracing_enabled
self.host = host
self.mask = mask

Expand Down
2 changes: 1 addition & 1 deletion tests/test_core_sdk.py
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ def test_create_generation():
assert generation_api.model_parameters == {
"max_tokens": "1000",
"temperature": "0.9",
"stop": ["user-1", "user-2"],
"stop": '["user-1","user-2"]',
}
assert generation_api.input == [
{"role": "system", "content": "You are a helpful assistant."},
Expand Down