Skip to content

fix(observe): default IO capture on decorated functions #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 2 commits into from
Jun 24, 2025
Merged

fix(observe): default IO capture on decorated functions #1221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a98d068
fix(observe): default IO capture on decorated functions
hassiebp Jun 24, 2025
d2ca701
Merge branch 'main' into fix-observe-default-io-capture
hassiebp Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions langfuse/_client/observe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ def observe(
*,
name: Optional[str] = None,
as_type: Optional[Literal["generation"]] = None,
capture_input: bool = True,
capture_output: bool = True,
capture_input: Optional[bool] = None,
capture_output: Optional[bool] = None,
transform_to_string: Optional[Callable[[Iterable], str]] = None,
) -> Callable[[F], F]: ...

Expand All @@ -76,8 +76,8 @@ def observe(
*,
name: Optional[str] = None,
as_type: Optional[Literal["generation"]] = None,
capture_input: bool = True,
capture_output: bool = True,
capture_input: Optional[bool] = None,
capture_output: Optional[bool] = None,
transform_to_string: Optional[Callable[[Iterable], str]] = None,
) -> Union[F, Callable[[F], F]]:
"""Wrap a function to create and manage Langfuse tracing around its execution, supporting both synchronous and asynchronous functions.
Expand Down Expand Up @@ -149,23 +149,33 @@ def sub_process():
LANGFUSE_OBSERVE_DECORATOR_IO_CAPTURE_ENABLED, "True"
).lower() not in ("false", "0")

should_capture_input = (
capture_input if capture_input is not None else function_io_capture_enabled
)

should_capture_output = (
capture_output
if capture_output is not None
else function_io_capture_enabled
)

def decorator(func: F) -> F:
return (
self._async_observe(
func,
name=name,
as_type=as_type,
capture_input=function_io_capture_enabled and capture_input,
capture_output=function_io_capture_enabled and capture_output,
capture_input=should_capture_input,
capture_output=should_capture_output,
transform_to_string=transform_to_string,
)
if asyncio.iscoroutinefunction(func)
else self._sync_observe(
func,
name=name,
as_type=as_type,
capture_input=function_io_capture_enabled and capture_input,
capture_output=function_io_capture_enabled and capture_output,
capture_input=should_capture_input,
capture_output=should_capture_output,
transform_to_string=transform_to_string,
)
)
Expand Down
Loading