fix(langchain): do not stringify metadata unnecessarily #1237
+22
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes metadata serialization in Langchain by preventing unnecessary string conversion, ensuring accurate data handling.
_flatten_and_serialize_metadatainattributes.pyto preserve string and integer values without additional JSON serialization.test_core_sdk.pyto verify metadata handling without unnecessary string conversion.test_otel.pyto ensure metadata is not double-serialized and is correctly handled in various scenarios.This description was created by
for 03fed0d. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Fixes metadata serialization in Langchain integration by preventing unnecessary string value conversion. This change addresses issues where string metadata values were being double-serialized in user quotes.
_flatten_and_serialize_metadatainlangfuse/_client/attributes.pyto preserve string and integer values without additional JSON serialization