Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Jul 4, 2025

Important

Fix return type of list() method in DatasetRunItemsClient and AsyncDatasetRunItemsClient to return PaginatedDatasetRunItems.

  • Behavior:
    • list() method in DatasetRunItemsClient and AsyncDatasetRunItemsClient now returns PaginatedDatasetRunItems instead of None.
  • Documentation:
    • Updated example usage in reference.md to reflect the return type change for list() method.

This description was created by Ellipsis for 0522389. You can customize this summary. It will automatically update as commits are pushed.

Greptile Summary

Disclaimer: Experimental PR review

Improves the DatasetRunItems API by standardizing the list method return type to PaginatedDatasetRunItems and removing the unnecessary response parameter, making the API more Pythonic and type-safe.

  • Modified langfuse/api/resources/dataset_run_items/client.py to return PaginatedDatasetRunItems directly instead of modifying a passed response object
  • Removed unused jsonable_encoder import and simplified method signature in dataset run items client
  • Updated langfuse/api/reference.md to reflect the simplified API interface

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp merged commit 9d38649 into main Jul 4, 2025
10 checks passed
@hassiebp hassiebp deleted the hassieb/lfe-5671-fix-datasetrunitems-response branch July 4, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: python SDK: langfuse.api.dataset_run_items.list(...) returns None object

2 participants