Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Aug 8, 2025

Disclaimer: Experimental PR review

Greptile Summary

This PR performs a comprehensive dependency cleanup, removing numerous third-party integration dependencies and associated tests from the langfuse-python project. The changes include:

Dependency Removals:

  • Removed 23+ development dependencies from pyproject.toml including vector databases (chromadb), LLM providers (anthropic, cohere, google-cloud-aiplatform, langchain-mistralai, langchain-groq, etc.), and supporting libraries (bson, boto3, pymongo, tiktoken)
  • Removed llama-index from poetry extras
  • Version bumped from 3.2.2 to 3.2.3

Test Suite Streamlining:

  • Completely removed test_extract_model.py (158 lines) which tested model name extraction across 20+ LangChain LLM providers
  • Removed RAG-related tests from test_langchain.py including retrieval chains, document loaders, text splitters, and vector store integrations
  • Removed MongoDB ObjectId serialization test and bson dependency from test_json.py
  • Removed llama-index integration utilities from tests/utils.py

This cleanup transforms the project from having comprehensive third-party integration testing to focusing on core Langfuse functionality with langchain-openai as the primary integration point. The changes align with reducing maintenance overhead and dependency complexity while preserving essential callback tracing and observability features that are central to Langfuse's purpose.

Confidence score: 3/5

  • This PR appears mostly safe but requires careful validation of test coverage
  • Score reflects potential gaps in integration testing and some inconsistencies in configuration
  • Pay close attention to pyproject.toml mypy overrides section which still references removed packages

Important

Remove unnecessary dependencies and related tests to streamline the project and focus on core functionality.

  • Dependencies:
    • Removed 23+ dependencies from pyproject.toml, including vector databases, LLM providers, and supporting libraries.
    • Removed llama-index from poetry extras.
    • Version bumped from 3.2.2 to 3.2.3.
  • Tests:
    • Removed test_extract_model.py which tested model name extraction for LangChain LLM providers.
    • Removed RAG-related tests from test_langchain.py.
    • Removed MongoDB ObjectId serialization test from test_json.py.
    • Removed llama-index integration utilities from tests/utils.py.

This description was created by Ellipsis for 30c52b6. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

hassiebp and others added 3 commits August 8, 2025 19:18
Bumps [starlette](https://github.com/encode/starlette) from 0.40.0 to 0.47.2.
- [Release notes](https://github.com/encode/starlette/releases)
- [Changelog](https://github.com/encode/starlette/blob/master/docs/release-notes.md)
- [Commits](Kludex/starlette@0.40.0...0.47.2)

---
updated-dependencies:
- dependency-name: starlette
  dependency-version: 0.47.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hassieb Pakzad <68423100+hassiebp@users.noreply.github.com>
@hassiebp hassiebp enabled auto-merge (squash) August 8, 2025 17:30
@hassiebp hassiebp disabled auto-merge August 9, 2025 09:10
@hassiebp hassiebp merged commit a288086 into main Aug 9, 2025
10 checks passed
@hassiebp hassiebp deleted the chore-bump-deps branch August 9, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants