Skip to content

Conversation

@hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Aug 13, 2025

Important

Specify opentelemetry-exporter-otlp-proto-http dependency in pyproject.toml.

  • Dependencies:
    • Change opentelemetry-exporter-otlp to opentelemetry-exporter-otlp-proto-http in pyproject.toml to specify the HTTP protocol version.

This description was created by Ellipsis for 236de15. You can customize this summary. It will automatically update as commits are pushed.

Disclaimer: Experimental PR review

Greptile Summary

This PR optimizes the OpenTelemetry dependency specification by replacing the generic opentelemetry-exporter-otlp metapackage with the specific opentelemetry-exporter-otlp-proto-http package. The version is also bumped from 3.2.3 to 3.2.4.

The change is motivated by Langfuse's actual usage pattern - the codebase only uses HTTP-based OTLP exports through the LangfuseSpanProcessor, which creates OTLPSpanExporter instances with HTTP endpoints. The original metapackage includes multiple transport implementations (gRPC, HTTP protobuf, and HTTP JSON), but Langfuse only needs the HTTP protobuf variant.

This dependency optimization follows OpenTelemetry's recommended best practices of installing specific exporter packages rather than metapackages to avoid unnecessary dependencies. The change maintains the same version constraint (^1.33.1) and functionality while reducing the overall dependency footprint by eliminating unused gRPC and JSON transport implementations.

The modification aligns with modern Python packaging practices of being explicit about dependencies and only including what's actually used by the application.

Confidence score: 5/5

  • This PR is extremely safe to merge with no risk of breaking changes
  • Score reflects a simple dependency optimization that maintains exact functionality while reducing bloat
  • No files require special attention as this is a straightforward dependency specification change

@hassiebp hassiebp changed the title chore: specifiy otlp http exporter dep chore: specify otlp http exporter dep Aug 13, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@hassiebp hassiebp merged commit 314e00c into main Aug 14, 2025
10 checks passed
@hassiebp hassiebp deleted the update-exporter-dep branch August 14, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants