Skip to content

fix(client): skip string serialization in attribute values #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 2 commits into from
Aug 14, 2025
Merged

fix(client): skip string serialization in attribute values #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa0b660
fix(client): skip string serialization in attribute values
hassiebp Aug 14, 2025
6e5d83f
push
hassiebp Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion langfuse/_client/attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,10 @@ def create_generation_attributes(


def _serialize(obj: Any) -> Optional[str]:
return json.dumps(obj, cls=EventSerializer) if obj is not None else None
if obj is None or isinstance(obj, str):
return obj

return json.dumps(obj, cls=EventSerializer)
Copy link

@j3r0lin j3r0lin Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure_ascii here should be False



def _flatten_and_serialize_metadata(
Expand Down
2 changes: 1 addition & 1 deletion tests/test_decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ async def level_1_function(*args, **kwargs):
assert generation.usage.output is not None
assert generation.usage.total is not None
print(generation)
assert generation.output == "2"
assert generation.output == 2


def test_generator_as_function_input():
Expand Down
4 changes: 2 additions & 2 deletions tests/test_openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def test_openai_chat_completion_stream(openai):
assert generation.data[0].usage.input is not None
assert generation.data[0].usage.output is not None
assert generation.data[0].usage.total is not None
assert generation.data[0].output == "2"
assert generation.data[0].output == 2
assert generation.data[0].completion_start_time is not None

# Completion start time for time-to-first-token
Expand Down Expand Up @@ -179,7 +179,7 @@ def test_openai_chat_completion_stream_with_next_iteration(openai):
assert generation.data[0].usage.input is not None
assert generation.data[0].usage.output is not None
assert generation.data[0].usage.total is not None
assert generation.data[0].output == "2"
assert generation.data[0].output == 2
assert generation.data[0].completion_start_time is not None

# Completion start time for time-to-first-token
Expand Down