Skip to content

Conversation

@qnnn
Copy link
Contributor

@qnnn qnnn commented Aug 22, 2025

Hello, I found that the current default values of LANGFUSE_FLUSH_AT and LANGFUSE_FLUSH_INTERVAL do not match the documentation comments.
So I updated the docs to align the default values according to the changes in #1229.


Important

Update default value documentation for LANGFUSE_FLUSH_AT and LANGFUSE_FLUSH_INTERVAL in environment_variables.py to align with OpenTelemetry constants.

  • Documentation:
    • Update default value docs for LANGFUSE_FLUSH_AT to "same as OTEL OTEL_BSP_MAX_EXPORT_BATCH_SIZE" in environment_variables.py.
    • Update default value docs for LANGFUSE_FLUSH_INTERVAL to "same as OTEL OTEL_BSP_SCHEDULE_DELAY" in environment_variables.py.

This description was created by Ellipsis for c3c05d2. You can customize this summary. It will automatically update as commits are pushed.

Disclaimer: Experimental PR review

Greptile Summary

This PR fixes documentation inconsistencies in the environment variables configuration file. Specifically, it updates the default value documentation for two environment variables: LANGFUSE_FLUSH_AT and LANGFUSE_FLUSH_INTERVAL.

The changes align the documentation with the actual implementation that was modified in PR #1229. Previously, the documentation incorrectly stated hardcoded default values (15 for flush_at and 1 second for flush_interval). However, the actual implementation now uses OpenTelemetry's native BatchSpanProcessor defaults when these environment variables are not explicitly set.

The updated documentation now correctly references:

  • OTEL_BSP_MAX_EXPORT_BATCH_SIZE (default: 512) for LANGFUSE_FLUSH_AT
  • OTEL_BSP_SCHEDULE_DELAY (default: 5000ms/5 seconds) for LANGFUSE_FLUSH_INTERVAL

This change ensures that developers reading the documentation will have accurate information about the actual runtime behavior of these configuration options. The fix is purely documentation-focused and maintains consistency between the codebase implementation and its documentation.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only updates documentation comments
  • Score reflects that this is a straightforward documentation fix with no code logic changes
  • No files require special attention as the change is limited to comment updates

Signed-off-by: qnnn <qiunan@cmbchina.com>
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@qnnn qnnn changed the title update default value docs for FLUSH_AT and FLUSH_INTERVAL chore: update default value docs for FLUSH_AT and FLUSH_INTERVAL Aug 22, 2025
@hassiebp
Copy link
Contributor

Thanks for your contribution, @qnnn !

@hassiebp hassiebp merged commit 9047253 into langfuse:main Aug 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants