fix(prompt-folders): update prompt in folder failed with wrong encoding #1335

aaguirre-rdit · 2025-09-11T20:55:10Z

The httpx module encodes some special characters like "/", so this behaviour can bring some issues when managing prompts in folders.

Without parsing these characters on the prompt name, the update_prompt method would return an error.

Traceback (most recent call last):
  File "/Users/xxx/Projects/langfuse-python/temp.py", line 9, in <module>
    lf.update_prompt(
  File "/Users/xxx/Projects/langfuse-python/langfuse/_client/client.py", line 2976, in update_prompt
    updated_prompt = self.api.prompt_version.update(
  File "/Users/xxx/Projects/langfuse-python/langfuse/api/resources/prompt_version/client.py", line 103, in update
    raise ApiError(status_code=_response.status_code, body=_response.text)
langfuse.api.core.api_error.ApiError: status_code: 404, body: <!DOCTYPE html><html lang="en"><head><meta charSet="utf-8" data-next-head=""/><meta name="viewport" content="width=device-width" data-next-head=""/><link rel="preload" href="/_next/static/css/4f61577301da82fe.css" as="style"/><link rel="stylesheet" href="/_next/static/css/4f61577301da82fe.css" data-n-g=""/><noscript data-n-css=""></noscript><script defer="" noModule="" src="/_next/static/chunks/polyfills-42372ed130431b0a.js"></script><script src="/_next/static/chunks/webpack-48446a2f46277bf5.js" defer=""></script><script src="/_next/static/chunks/framework-39e74fc25319e84b.js" defer=""></script><script src="/_next/static/chunks/main-52f0abb496765ba2.js" defer=""></script><script src="/_next/static/chunks/pages/_app-394ef6f5ffa66063.js" defer=""></script><script src="/_next/static/chunks/pages/_error-f8e5d23f5659a71d.js" defer=""></script><script src="/_next/static/WLAoST7iIb6seR22m02hS/_buildManifest.js" defer=""></script><script src="/_next/static/WLAoST7iIb6seR22m02hS/_ssgManifest.js" defer=""></script></head><body><link rel="preload" as="image" href="/icon.svg"/><div id="__next"><script>((e,i,s,u,m,a,l,h)=>{let d=document.documentElement,w=["light","dark"];function p(n){(Array.isArray(e)?e:[e]).forEach(y=>{let k=y==="class",S=k&&a?m.map(f=>a[f]||f):m;k?(d.classList.remove(...S),d.classList.add(a&&a[n]?a[n]:n)):d.setAttribute(y,n)}),R(n)}function R(n){h&&w.includes(n)&&(d.style.colorScheme=n)}function c(){return window.matchMedia("(prefers-color-scheme: dark)").matches?"dark":"light"}if(u)p(u);else try{let n=localStorage.getItem(i)||s,y=l&&n==="system"?c():n;p(y)}catch(n){}})("class","theme","system",null,["light","dark"],null,true,true)</script><div class="flex min-h-full flex-1 flex-col justify-center py-12 sm:px-6 lg:px-8" data-sentry-component="Spinner" data-sentry-source-file="spinner.tsx"><div class="sm:mx-auto sm:w-full sm:max-w-md"><img src="/icon.svg" width="42" height="42" alt="Langfuse Icon" class="mx-auto motion-safe:animate-spin" data-sentry-component="LangfuseIcon" data-sentry-source-file="LangfuseLogo.tsx"/><h2 class="mt-5 text-center text-2xl font-bold leading-9 tracking-tight text-primary">Loading<!-- --> ...</h2></div></div></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{"statusCode":404}},"page":"/_error","query":{},"buildId":"WLAoST7iIb6seR22m02hS","nextExport":true,"isFallback":false,"gip":true,"locale":"en","locales":["en"],"defaultLocale":"en","scriptLoader":[]}</script></body></html>

I have updated the method to parse the name so that the prompt name, if containing a "/" would be handled correctly in the API, and added an additional test to the prompt tests.

Important

Fix update_prompt in client.py to handle prompt names with slashes by URL encoding them, and add a test for prompts in folders.

Behavior:
- Fix update_prompt in client.py to handle prompt names with slashes by URL encoding them using _url_encode().
- Adds test test_update_prompt_in_folder in test_prompt.py to verify correct handling of prompts in folders.
Misc:
- No changes to constants or other configurations.
- No new dependencies added.

^{This description was created by}^{for b66eef9. You can customize this summary. It will automatically update as commits are pushed.}

Disclaimer: Experimental PR review

Greptile Summary

Updated On: 2025-09-11 20:56:18 UTC

This PR fixes a critical bug in the update_prompt method where prompts organized in folder structures (with names containing forward slashes like folder/prompt-name) would fail with 404 errors. The issue stemmed from the httpx library automatically URL-encoding special characters like / to %2F, causing the API to look for a prompt with the encoded name rather than the original name.

The fix applies the existing _url_encode method to the prompt name parameter before making the API call, ensuring consistent behavior with other prompt-related methods like get_prompt that already handle URL encoding. The solution leverages the existing _url_encode utility method (lines 2987-2998 in client.py) that properly handles httpx version compatibility and character escaping.

A comprehensive test case test_update_prompt_in_folder was added to verify that prompts with folder-like names can be successfully created, retrieved, and updated. This test follows the same pattern as existing prompt tests but specifically validates the URL encoding fix by using a prompt name containing a forward slash.

The change integrates seamlessly with the existing codebase by following established patterns for URL encoding in other API methods, ensuring consistency across the Langfuse client's prompt management functionality.

Confidence score: 4/5

This PR addresses a specific, well-documented bug with a targeted fix that follows existing patterns
Score reflects the straightforward nature of the fix and comprehensive test coverage, though minor risk exists around URL encoding edge cases
Pay close attention to the _url_encode method implementation and the new test case validation

…rs - name contains slash

CLAassistant · 2025-09-11T20:55:16Z

All committers have signed the CLA.

greptile-apps

Reviewing changes made in this pull request

nimarb

looks good, thank you for the contribution

Hotfix for SDK Client update_prompt failing when prompts are in folde…

b66eef9

…rs - name contains slash

greptile-apps bot reviewed Sep 11, 2025

View reviewed changes

Merge branch 'main' into fix/update_prompt_foldered_names

65bf60d

nimarb changed the title ~~Hotfix for update_prompt failing when prompts are in folders~~ fix(prompt-folders): update prompt in folder failed with wrong encoding Sep 16, 2025

Merge branch 'main' into fix/update_prompt_foldered_names

2e740dc

nimarb self-requested a review September 16, 2025 13:17

nimarb approved these changes Sep 16, 2025

View reviewed changes

nimarb enabled auto-merge (squash) September 16, 2025 14:59

nimarb disabled auto-merge September 16, 2025 14:59

nimarb merged commit abf3628 into langfuse:main Sep 16, 2025
8 of 16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(prompt-folders): update prompt in folder failed with wrong encoding #1335

fix(prompt-folders): update prompt in folder failed with wrong encoding #1335

Uh oh!

aaguirre-rdit commented Sep 11, 2025 •

edited by greptile-apps bot

Loading

Uh oh!

CLAassistant commented Sep 11, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

nimarb left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(prompt-folders): update prompt in folder failed with wrong encoding #1335

fix(prompt-folders): update prompt in folder failed with wrong encoding #1335

Uh oh!

Conversation

aaguirre-rdit commented Sep 11, 2025 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Disclaimer: Experimental PR review

Greptile Summary

Confidence score: 4/5

Uh oh!

CLAassistant commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

nimarb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aaguirre-rdit commented Sep 11, 2025 •

edited by greptile-apps bot

Loading

CLAassistant commented Sep 11, 2025 •

edited

Loading