feat(api): update API spec from langfuse/langfuse ac2936d316ccde414fe932edfedecf91c51fd594 #1366
Conversation
…932edfedecf91c51fd594
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| ) -> T_Result: | ||
| if self is BlobStorageIntegrationType.S_3: | ||
| return s_3() | ||
| if self is BlobStorageIntegrationType.S_3_COMPATIBLE: | ||
| return s_3_compatible() | ||
| if self is BlobStorageIntegrationType.AZURE_BLOB_STORAGE: | ||
| return azure_blob_storage() |
There was a problem hiding this comment.
logic: Missing return statement or exception handling - if self doesn't match any of the defined enum values, the method will implicitly return None, violating the T_Result return type annotation
| ) -> T_Result: | |
| if self is BlobStorageIntegrationType.S_3: | |
| return s_3() | |
| if self is BlobStorageIntegrationType.S_3_COMPATIBLE: | |
| return s_3_compatible() | |
| if self is BlobStorageIntegrationType.AZURE_BLOB_STORAGE: | |
| return azure_blob_storage() | |
| ) -> T_Result: | |
| if self is BlobStorageIntegrationType.S_3: | |
| return s_3() | |
| if self is BlobStorageIntegrationType.S_3_COMPATIBLE: | |
| return s_3_compatible() | |
| if self is BlobStorageIntegrationType.AZURE_BLOB_STORAGE: | |
| return azure_blob_storage() | |
| raise ValueError(f"Unknown BlobStorageIntegrationType: {self}") |
| ) -> T_Result: | ||
| if self is BlobStorageIntegrationFileType.JSON: | ||
| return json() | ||
| if self is BlobStorageIntegrationFileType.CSV: | ||
| return csv() | ||
| if self is BlobStorageIntegrationFileType.JSONL: | ||
| return jsonl() |
There was a problem hiding this comment.
logic: Missing return statement or exception for unmatched cases. If an invalid enum value exists, this method will return None instead of T_Result, violating the type contract.
| ) -> T_Result: | |
| if self is BlobStorageIntegrationFileType.JSON: | |
| return json() | |
| if self is BlobStorageIntegrationFileType.CSV: | |
| return csv() | |
| if self is BlobStorageIntegrationFileType.JSONL: | |
| return jsonl() | |
| ) -> T_Result: | |
| if self is BlobStorageIntegrationFileType.JSON: | |
| return json() | |
| if self is BlobStorageIntegrationFileType.CSV: | |
| return csv() | |
| if self is BlobStorageIntegrationFileType.JSONL: | |
| return jsonl() | |
| raise ValueError(f"Unknown BlobStorageIntegrationFileType: {self}") |
| ) -> T_Result: | ||
| if self is BlobStorageExportFrequency.HOURLY: | ||
| return hourly() | ||
| if self is BlobStorageExportFrequency.DAILY: | ||
| return daily() | ||
| if self is BlobStorageExportFrequency.WEEKLY: | ||
| return weekly() |
There was a problem hiding this comment.
logic: Missing return statement or exception for unmatched enum values - the method could return None if a new enum value is added but not handled
| if self is BlobStorageExportMode.FROM_TODAY: | ||
| return from_today() | ||
| if self is BlobStorageExportMode.FROM_CUSTOM_DATE: | ||
| return from_custom_date() |
There was a problem hiding this comment.
logic: Missing return statement or raise exception for unhandled enum values - the visit method should handle the case where none of the conditions match
| return from_custom_date() | |
| return from_custom_date() | |
| raise ValueError(f"Unhandled BlobStorageExportMode: {self}") |
| # This file was auto-generated by Fern from our API Definition. | ||
|
|
||
| from langfuse.api.core.query_encoder import encode_query | ||
| from langfuse.core.query_encoder import encode_query |
There was a problem hiding this comment.
logic: Import path 'langfuse.core.query_encoder' does not exist in current repository structure. The 'langfuse/core/' directory is not present in the codebase, which will cause this import to fail at runtime.
| from langfuse.core.query_encoder import encode_query | |
| from langfuse.api.core.query_encoder import encode_query |
Important
Add blob storage integration management and organization membership deletion functionalities to the API.
BlobStorageIntegrationsClientandAsyncBlobStorageIntegrationsClientinclient.pyto manage blob storage integrations.BlobStorageIntegrationResponse,CreateBlobStorageIntegrationRequest, and others intypes/.client.pyfor managing organization and project memberships, includingdelete_organization_membershipanddelete_project_membership.DeleteMembershipRequestandMembershipDeletionResponsemodels intypes/.reference.mdwith new endpoints and usage examples for blob storage integrations and memberships.README.mdto correct a typo.test_http_client.pyandtest_query_encoding.pyto reflect new changes.This description was created by
for 7cd74cd. You can customize this summary. It will automatically update as commits are pushed.
Disclaimer: Experimental PR review
Greptile Summary
Updated On: 2025-09-18 10:30:40 UTC
This PR is an automated API specification update from the main Langfuse repository (commit
ac2936d316ccde414fe932edfedecf91c51fd594) that adds comprehensive blob storage integration functionality and enhances organization membership management capabilities.Key additions include:
Blob Storage Integrations: A complete new API resource (
blob_storage_integrations) with support for S3, S3-compatible storage, and Azure Blob Storage. This includes:Organization Management Enhancements: New DELETE endpoints for removing organization and project memberships with proper request/response models (
DeleteMembershipRequest,MembershipDeletionResponse)API Evolution: The batch ingestion endpoint is now marked as legacy with guidance to migrate to the OpenTelemetry endpoint (
/api/public/otel)Enhanced Filtering: The ScoreV2 API now supports session-level filtering via a new
session_idparameterDocumentation Improvements: Better field filtering explanations for trace endpoints, clarifying that excluded fields return empty arrays or sentinel values (-1)
All changes follow the established Fern-generated patterns in the codebase, maintaining consistency with existing API resources. The blob storage integration represents a significant new feature enabling automated data exports to cloud storage providers with flexible scheduling and format options.
Confidence score: 3/5