Skip to content

Conversation

@langfuse-bot
Copy link
Collaborator

@langfuse-bot langfuse-bot commented Oct 13, 2025

Important

Add queue_id field to multiple classes to reference annotation queues, updating docstrings for clarity.

  • Behavior:
    • Add queue_id field to ScoreBody and CreateScoreRequest classes, referencing an annotation queue.
    • Update queue_id docstring in BaseScore and BaseScoreV1 to clarify its purpose.
  • Fields:
    • queue_id is optional and uses alias queueId in all classes.
  • Files:
    • Changes in base_score.py, base_score_v_1.py, score_body.py, and create_score_request.py.

This description was created by Ellipsis for 46e409f. You can customize this summary. It will automatically update as commits are pushed.

Disclaimer: Experimental PR review

Greptile Overview

Updated On: 2025-10-13 08:33:47 UTC

Summary

This PR updates the auto-generated API client to add support for annotation queue tracking on scores. The changes add an optional queue_id field to score creation and response types.

Key changes:

  • Added optional queue_id field to ScoreBody and CreateScoreRequest types to support annotation queue references
  • Updated docstrings for existing queue_id field in BaseScore and BaseScoreV1 for improved clarity
  • All changes are backward compatible as the new field is optional with a default value of None

Technical details:

  • These are auto-generated files from the Fern API specification
  • The new field follows the existing pattern with pydantic field alias (queueIdqueue_id)
  • No breaking changes to existing SDK functionality

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Auto-generated API spec update that adds an optional field. The change is backward compatible, follows existing patterns, and cannot break existing functionality since the field defaults to None
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
langfuse/api/resources/ingestion/types/score_body.py 5/5 Added optional queue_id field to support annotation queue tracking
langfuse/api/resources/score/types/create_score_request.py 5/5 Added optional queue_id field to support annotation queue tracking

Sequence Diagram

sequenceDiagram
    participant User
    participant Client as Langfuse Client
    participant ScoreBody
    participant API as Langfuse API
    participant Queue as Annotation Queue

    User->>Client: create_score(name, value, ...)
    Client->>Client: Generate score_id
    Client->>ScoreBody: Create ScoreBody instance
    Note over ScoreBody: New optional field:<br/>queue_id (queueId)
    ScoreBody->>ScoreBody: Validate fields
    Client->>Client: Create score-create event
    Client->>API: Send score via ingestion endpoint
    alt Score has queue_id
        API->>Queue: Associate score with annotation queue
        Queue-->>API: Confirmation
    end
    API-->>Client: Score created successfully
    Client-->>User: Score created
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@hassiebp hassiebp merged commit 496aca3 into main Oct 13, 2025
11 checks passed
@hassiebp hassiebp deleted the api-spec-bot-fa2979b branch October 13, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants