Skip to content

fix(client): HTTP headers concatenated by dashes instead of snakecase #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 5 commits into from
Oct 17, 2025
Merged

fix(client): HTTP headers concatenated by dashes instead of snakecase #1404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47967b9
fix(client): HTTP headers concatenated by dashes instead of snakecase
hassiebp Oct 16, 2025
7d1f0f6
Update langfuse/_client/span_processor.py
hassiebp Oct 16, 2025
7218b37
Update tests/test_additional_headers_simple.py
hassiebp Oct 16, 2025
3e387fb
Update langfuse/_utils/request.py
hassiebp Oct 16, 2025
4b627c5
Update tests/test_additional_headers_simple.py
hassiebp Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions langfuse/_client/span_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ def __init__(
# Prepare default headers
default_headers = {
"Authorization": basic_auth_header,
"x_langfuse_sdk_name": "python",
"x_langfuse_sdk_version": langfuse_version,
"x_langfuse_public_key": public_key,
"x-langfuse-sdk-name": "python",
"x-langfuse-sdk-version": langfuse_version,
"x-langfuse-public-key": public_key,
}

# Merge additional headers if provided
Expand Down
6 changes: 3 additions & 3 deletions langfuse/_utils/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ def generate_headers(self) -> dict:
f"{self._public_key}:{self._secret_key}".encode("utf-8")
).decode("ascii"),
"Content-Type": "application/json",
"x_langfuse_sdk_name": "python",
"x_langfuse_sdk_version": self._version,
"x_langfuse_public_key": self._public_key,
"x-langfuse-sdk-name": "python",
"x-langfuse-sdk-version": self._version,
"x-langfuse-public-key": self._public_key,
}

def batch_post(self, **kwargs: Any) -> httpx.Response:
Expand Down
8 changes: 4 additions & 4 deletions tests/test_additional_headers_simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ def test_span_processor_has_additional_headers_in_otel_exporter(self):

# Verify default headers are still present
assert "Authorization" in exporter._headers
assert "x_langfuse_sdk_name" in exporter._headers
assert "x_langfuse_public_key" in exporter._headers
assert "x-langfuse-sdk-name" in exporter._headers
assert "x-langfuse-public-key" in exporter._headers

# Check that our override worked
assert exporter._headers["X-Override-Default"] == "override-value"
Expand All @@ -179,5 +179,5 @@ def test_span_processor_none_additional_headers_works(self):

# Verify default headers are present
assert "Authorization" in exporter._headers
assert "x_langfuse_sdk_name" in exporter._headers
assert "x_langfuse_public_key" in exporter._headers
assert "x-langfuse-sdk-name" in exporter._headers
assert "x-langfuse-public-key" in exporter._headers