Skip to content

fix(client): handle update_current_trace on non recorded spans gracefully #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 1 commit into from
Nov 11, 2025
Merged

fix(client): handle update_current_trace on non recorded spans gracefully #1432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion langfuse/_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,7 +1664,7 @@ def update_current_trace(

current_otel_span = self._get_current_otel_span()

if current_otel_span is not None:
if current_otel_span is not None and current_otel_span.is_recording():
existing_observation_type = current_otel_span.attributes.get( # type: ignore[attr-defined]
LangfuseOtelSpanAttributes.OBSERVATION_TYPE, "span"
)
Expand Down