Skip to content

fix(openai): handle pydantic BaseModel as metadata #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 1 commit into from
Nov 24, 2025
Merged

fix(openai): handle pydantic BaseModel as metadata #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion langfuse/openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,10 @@ def _get_langfuse_data_from_kwargs(resource: OpenAiDefinition, kwargs: Any) -> A
and not isinstance(metadata, NotGiven)
and not isinstance(metadata, dict)
):
raise TypeError("metadata must be a dictionary")
if isinstance(metadata, BaseModel):
metadata = metadata.model_dump()
else:
metadata = {}

model = kwargs.get("model", None) or None

Expand Down
10 changes: 0 additions & 10 deletions tests/test_openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,16 +607,6 @@ def test_fails_wrong_name(openai):
)


def test_fails_wrong_metadata(openai):
with pytest.raises(TypeError, match="metadata must be a dictionary"):
openai.OpenAI().completions.create(
metadata="metadata",
model="gpt-3.5-turbo-instruct",
prompt="1 + 1 = ",
temperature=0,
)


def test_fails_wrong_trace_id(openai):
with pytest.raises(TypeError, match="trace_id must be a string"):
openai.OpenAI().completions.create(
Expand Down
Loading