Skip to content

fix(resource-manager): flush custom tracer provider if provided #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 3 commits into from
Dec 12, 2025
Merged

fix(resource-manager): flush custom tracer provider if provided #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fc8ef7
fix(resource-manager): flush custom tracer provider if provided
hassiebp Dec 8, 2025
54010b6
Merge branch 'main' into hassieb/lfe-7980-bug-sdk-python-doesnt-flush…
hassiebp Dec 8, 2025
00ef9a7
push
hassiebp Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions langfuse/_client/resource_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def _initialize_instance(
self.sample_rate = sample_rate
self.blocked_instrumentation_scopes = blocked_instrumentation_scopes
self.additional_headers = additional_headers
self.tracer_provider = None
self.tracer_provider: Optional[TracerProvider] = None

# OTEL Tracer
if tracing_enabled:
Expand Down Expand Up @@ -399,9 +399,10 @@ def _stop_and_join_consumer_threads(self) -> None:
)

def flush(self) -> None:
tracer_provider = cast(TracerProvider, otel_trace_api.get_tracer_provider())
if not isinstance(tracer_provider, otel_trace_api.ProxyTracerProvider):
tracer_provider.force_flush()
if self.tracer_provider is not None and not isinstance(
self.tracer_provider, otel_trace_api.ProxyTracerProvider
):
self.tracer_provider.force_flush()
langfuse_logger.debug("Successfully flushed OTEL tracer provider")

self._score_ingestion_queue.join()
Expand All @@ -414,9 +415,10 @@ def shutdown(self) -> None:
# Unregister the atexit handler first
atexit.unregister(self.shutdown)

tracer_provider = cast(TracerProvider, otel_trace_api.get_tracer_provider())
if not isinstance(tracer_provider, otel_trace_api.ProxyTracerProvider):
tracer_provider.force_flush()
if self.tracer_provider is not None and not isinstance(
self.tracer_provider, otel_trace_api.ProxyTracerProvider
):
self.tracer_provider.force_flush()

self._stop_and_join_consumer_threads()

Expand Down
2 changes: 1 addition & 1 deletion tests/test_propagate_attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def get_span_by_name(self, memory_exporter, name: str) -> dict:
AssertionError: If zero or more than one span with the name exists
"""
spans = self.get_spans_by_name(memory_exporter, name)
assert len(spans) == 1, f"Expected 1 span named '{name}', found {len(spans)}"
assert len(spans) > 0, f"Expected at least 1 span named '{name}'"
return spans[0]

def verify_missing_attribute(self, span_data: dict, attr_key: str):
Expand Down
Loading