Skip to content

fix(client): flush on shutdown #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 2 commits into from
Dec 16, 2025
Merged

fix(client): flush on shutdown #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d1b92
fix(client): flush on shutdown
hassiebp Dec 15, 2025
bcc5880
push
hassiebp Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions langfuse/_client/resource_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,11 +415,7 @@ def shutdown(self) -> None:
# Unregister the atexit handler first
atexit.unregister(self.shutdown)

if self.tracer_provider is not None and not isinstance(
self.tracer_provider, otel_trace_api.ProxyTracerProvider
):
self.tracer_provider.force_flush()

self.flush()
self._stop_and_join_consumer_threads()


Expand Down
3 changes: 2 additions & 1 deletion tests/test_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def test_create_dataset_item():
source_trace_id=generation.trace_id,
)
langfuse.create_dataset_item(
input="Hello",
dataset_name=name,
)

Expand All @@ -67,7 +68,7 @@ def test_create_dataset_item():
assert dataset.items[1].source_trace_id == generation.trace_id
assert dataset.items[1].dataset_name == name

assert dataset.items[0].input is None
assert dataset.items[0].input == "Hello"
assert dataset.items[0].expected_output is None
assert dataset.items[0].metadata is None
assert dataset.items[0].source_observation_id is None
Expand Down
Loading