feat: extend coverage of API #827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcklingen
reviewed
Aug 1, 2024
…ecific prompt by name
…ecific prompt by name
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
The pull request extends the Langfuse API coverage by adding new methods for fetching scores, prompts, and datasets, and updating the linking of dataset items.
- Added
fetch_score,fetch_scores,fetch_prompts,get_datasets, andget_dataset_itemsmethods inlangfuse/client.py. - Updated
linkmethod inDatasetItemClientto handle various input types. - Added new test cases in
tests/test_core_sdk.pyto validate the new API endpoints and ensure correct data retrieval.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
marcklingen
requested review from
hassiebp
and removed request for
marcklingen
Contributor
|
Closing this in favor of #1098 |
Contributor
|
Thanks again Richie though ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.