Use exponential backoff for connection retries #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrisc
force-pushed
the
unreachable_kdc
branch
2 times, most recently
from
a8d5c15 to
eee16d0
Compare
jrisc
force-pushed
the
unreachable_kdc
branch
2 times, most recently
from
6cd07a4 to
4284384
Compare
jrisc
changed the title
Collaborator
Author
|
I was trying to add the connection type, IP address, and port number in the warning message, but apparently such information cannot be fetched from the socket in Python 2. So I am doing to make some additional changes to report the timeout back to the parent function (where the address is available) to report the timeout rather than each connection failure. |
Member
|
We still care about python 2 ? |
Collaborator
Author
|
Yes, for RHEL 7 ELS until 2028. |
jrisc
force-pushed
the
unreachable_kdc
branch
from
4284384 to
b33ebfa
Compare
Collaborator
Author
|
I made some improvements to log the timeout only once per @simo5 I tested this code for Python 2. Could you enabled the CI tests so we can confirm it works with Python 3 too? |
jrisc
changed the title
jrisc
force-pushed
the
unreachable_kdc
branch
from
b33ebfa to
c28dc0b
Compare
simo5
approved these changes
Nov 21, 2024
jrisc
force-pushed
the
unreachable_kdc
branch
2 times, most recently
from
c054d97 to
75eb76f
Compare
Calls to socket.connect() are non-blocking, hence all subsequent calls to socket.sendall() will fail if the target KDC service is temporarily or indefinitely unreachable. Since the kdcproxy task uses busy-looping, it results in the journal to be flooded with warning logs. This commit introduces a per-socket reactivation delay which increases exponentially as the number of reties is incremented, until timeout is reached (i.e. 100ms, 200ms, 400ms, 800ms, 1.6s, 3.2s, ...). Signed-off-by: Julien Rische <jrische@redhat.com>
Signed-off-by: Julien Rische <jrische@redhat.com>
jrisc
force-pushed
the
unreachable_kdc
branch
from
75eb76f to
c8a69db
Compare
Signed-off-by: Julien Rische <jrische@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
socket.connect()are non-blocking, hence all subsequent calls tosocket.sendall()will fail if the target KDC service is temporarily or indefinitely unreachable. Since the kdcproxy task uses busy-looping, it results in the journal to be flooded with warning logs.This pull request introduces a per-socket reactivation delay which increases exponentially as the number of reties is incremented, until timeout is reached (i.e. 100ms, 200ms, 400ms, 800ms, 1.6s, 3.2s, ...).
(Also replaces the default
rootlogger with a dedicatedkdcproxyone)