Skip to content

Conversation

@joker23
Copy link
Contributor

@joker23 joker23 commented Dec 24, 2025

SDK-1711

This PR reverts detox and locked it in 20.46.0 as 20.46.1 is breaking the build. There is nothing really obvious on the changes that would have caused the breakage so we will need to investigate more later.


Note

Updates E2E-related tooling for the React Native example app.

  • Pins detox to 20.46.3 (was caret range)
  • Upgrades @config-plugins/detox to 11.0.0
  • Removes @types/detox from devDependencies

Written by Cursor Bugbot for commit ff22f9a. This will update automatically on new commits. Configure here.

@joker23 joker23 requested a review from a team as a code owner December 24, 2025 21:31
@github-actions
Copy link
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 169118 bytes
Compressed size limit: 200000
Uncompressed size: 789399 bytes

@github-actions
Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25394 bytes
Compressed size limit: 26000
Uncompressed size: 124693 bytes

@github-actions
Copy link
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 18527 bytes
Compressed size limit: 20000
Uncompressed size: 95226 bytes

@github-actions
Copy link
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 23135 bytes
Compressed size limit: 25000
Uncompressed size: 80393 bytes

"@types/react": "~18.2.55",
"@types/react-native-dotenv": "^0.2.1",
"detox": "^20.17.1",
"detox": "20.46.3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detox version mismatch with PR intent

The PR description states the intent is to revert detox to 20.46.0 because 20.46.1 is breaking the build, but the actual version set is 20.46.3. This version is newer than the problematic 20.46.1 and likely won't fix the build issue as intended.

Fix in Cursor Fix in Web

@joker23 joker23 changed the title test: revert detox version to last known success test: pin detox package version to avoid breaking patches Jan 2, 2026
@joker23
Copy link
Contributor Author

joker23 commented Jan 2, 2026

NOTE if the latest patch is working then we can close this PR without merge

@joker23 joker23 closed this Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants