feat(icons): sync and connect icons with figma library#1850
Draft
pd-sa-github-launchpad-ui wants to merge 1 commit intomainfrom
Draft
feat(icons): sync and connect icons with figma library#1850pd-sa-github-launchpad-ui wants to merge 1 commit intomainfrom
pd-sa-github-launchpad-ui wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: eaf1b1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
|
Size Change: 0 B Total Size: 533 kB ℹ️ View Unchanged
|
| props: { | ||
| name: 'Icon', | ||
| }, | ||
| example: () => <Icon name="Icon" />, |
Contributor
There was a problem hiding this comment.
hm, yeah icon is not a valid name for an icon. if we want this example we'd need to have name= one of the values on this check failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is an automated icon sync with LaunchPad Figma library. If you resync while this PR is open, the updated changes will be added to this same PR.