Skip to content

chore: Fix broken pypi publish action #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keelerm84 merged 1 commit into from
Nov 22, 2024
+7 −24
Merged

chore: Fix broken pypi publish action #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .github/actions/publish/action.yml
View file
Open in desktop

This file was deleted.

7 changes: 4 additions & 3 deletions .github/workflows/manual-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ jobs:
- uses: ./.github/actions/build
id: build

- uses: ./.github/actions/publish
- name: Publish package distributions to PyPI
if: ${{ inputs.dry_run == false }}
uses: pypa/gh-action-pypi-publish@release/v1
Copy link

@webknjaz webknjaz Dec 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the security recommendation is to have this in a dedicated job and avoid giving elevated OIDC privileges to transitive build dependencies.

with:
token: ${{env.PYPI_AUTH_TOKEN}}
dry_run: ${{ inputs.dry_run }}
password: ${{env.PYPI_AUTH_TOKEN}}
Copy link

@webknjaz webknjaz Dec 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary with OIDC: https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/


release-provenance:
needs: [ 'build-publish' ]
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ jobs:
- uses: ./.github/actions/build-docs
if: ${{ steps.release.outputs.releases_created == 'true' }}

- uses: ./.github/actions/publish
- name: Publish package distributions to PyPI
if: ${{ steps.release.outputs.releases_created == 'true' }}
uses: pypa/gh-action-pypi-publish@release/v1
with:
token: ${{env.PYPI_AUTH_TOKEN}}
dry_run: false
password: ${{env.PYPI_AUTH_TOKEN}}

release-provenance:
needs: [ 'release-package' ]
Expand Down