Skip to content

chore: Drop python 3.8 test support #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keelerm84 merged 1 commit into from
May 29, 2025
Merged

chore: Drop python 3.8 test support #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ name: Quality control checks

on:
push:
branches: [ main, 'feat/**' ]
branches: [main, "feat/**"]
paths-ignore:
- '**.md' # Do not need to run CI for markdown changes.
- "**.md" # Do not need to run CI for markdown changes.
pull_request:
branches: [ main, 'feat/**' ]
branches: [main, "feat/**"]
paths-ignore:
- '**.md'
- "**.md"

jobs:
linux:
Expand All @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12"]

services:
redis:
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v4
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/manual-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_dispatch:
inputs:
dry_run:
description: 'Is this a dry run? If so no package will be published.'
description: "Is this a dry run? If so no package will be published."
type: boolean
required: true

Expand All @@ -21,16 +21,16 @@ jobs:

- uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

- name: Install poetry
uses: abatilo/actions-poetry@7b6d33e44b4f08d7021a1dee3c044e9c253d6439

- uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0
name: 'Get PyPI token'
name: "Get PyPI token"
with:
aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
ssm_parameter_pairs: '/production/common/releasing/pypi/token = PYPI_AUTH_TOKEN'
ssm_parameter_pairs: "/production/common/releasing/pypi/token = PYPI_AUTH_TOKEN"

- uses: ./.github/actions/build
id: build
Expand All @@ -42,7 +42,7 @@ jobs:
password: ${{env.PYPI_AUTH_TOKEN}}

release-provenance:
needs: [ 'build-publish' ]
needs: ["build-publish"]
permissions:
actions: read
id-token: write
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Run Release Please

on:
push:
branches: [ main ]
branches: [main]

jobs:
release-package:
Expand All @@ -27,18 +27,18 @@ jobs:
- uses: actions/setup-python@v5
if: ${{ steps.release.outputs.releases_created == 'true' }}
with:
python-version: 3.8
python-version: 3.9

- name: Install poetry
if: ${{ steps.release.outputs.releases_created == 'true' }}
uses: abatilo/actions-poetry@7b6d33e44b4f08d7021a1dee3c044e9c253d6439

- uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0
if: ${{ steps.release.outputs.releases_created == 'true' }}
name: 'Get PyPI token'
name: "Get PyPI token"
with:
aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
ssm_parameter_pairs: '/production/common/releasing/pypi/token = PYPI_AUTH_TOKEN'
ssm_parameter_pairs: "/production/common/releasing/pypi/token = PYPI_AUTH_TOKEN"

- uses: ./.github/actions/build
id: build
Expand All @@ -54,7 +54,7 @@ jobs:
password: ${{env.PYPI_AUTH_TOKEN}}

release-provenance:
needs: [ 'release-package' ]
needs: ["release-package"]
if: ${{ needs.release-package.outputs.release-created == 'true' }}
permissions:
actions: read
Expand Down