Skip to content

Conversation

@keelerm84
Copy link
Member

@keelerm84 keelerm84 commented Oct 24, 2025

Note

Refactors data system builders to be config-aware and updates FDv2/client integration and tests accordingly.

  • Data system config API:
    • Change Builder type to Callable[[Config], T] in ldclient/config.py and impl/datasystem/config.py.
    • Convert default(), streaming(), polling(), daemon(), persistent_store() to no-arg helpers that return builders which accept Config.
    • Internal polling/streaming builder factories now return functions (config) -> DataSource.
  • FDv2:
    • Update constructor to FDv2(config: Config, data_system_config: DataSystemConfig) and derive offline state from config.offline.
    • Use data_system_config for initializers/synchronizers/store; pass config into initializer/synchronizer builders.
    • Minor logging cleanup to parameterized logging.
  • Client:
    • Instantiate FDv2 with FDv2(self._config, datasystem_config).
  • TestDataV2:
    • build_initializer/build_synchronizer now accept a Config arg (unused) to match new Builder signature.
  • Tests:
    • Update all tests to new signatures and helper APIs; add Config(sdk_key="dummy") where needed.
    • Minor formatting adjustments in test stubs.

Written by Cursor Bugbot for commit 77b1e82. This will update automatically on new commits. Configure here.

@keelerm84 keelerm84 requested a review from a team as a code owner October 24, 2025 14:48
@keelerm84 keelerm84 force-pushed the mk/sdk-1504/persistence branch from 4e44909 to e88a705 Compare October 30, 2025 19:43
Base automatically changed from mk/sdk-1504/persistence to feat/fdv2 October 30, 2025 20:03
@keelerm84 keelerm84 force-pushed the mk/sdk-1512/fdv2-default-config-dep branch from 8e0eae3 to 8ccfd3e Compare October 30, 2025 20:08
@keelerm84 keelerm84 force-pushed the mk/sdk-1512/fdv2-default-config-dep branch from 8ccfd3e to 77b1e82 Compare October 30, 2025 20:16
@keelerm84 keelerm84 merged commit 394f6d5 into feat/fdv2 Oct 30, 2025
23 of 24 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1512/fdv2-default-config-dep branch October 30, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants