chore: Add FDv2-compatible contract test support#362
Merged
kinyoklion merged 2 commits intofeat/fdv2from Nov 5, 2025
Merged
Conversation
8ccfd3e to
77b1e82
Compare
Base automatically changed from
mk/sdk-1512/fdv2-default-config-dep
to
feat/fdv2
October 30, 2025 20:40
e55dca5 to
9c3cd49
Compare
kinyoklion
reviewed
Nov 3, 2025
| Stops the streaming synchronizer, closing any open connections. | ||
| """ | ||
| log.info("Stopping StreamingUpdateProcessor") | ||
| self._running = False |
Member
There was a problem hiding this comment.
I assume no threading concerns in this implementation?
Member
Author
There was a problem hiding this comment.
I don't believe there should be. The data system starts it's own thread which creates and destroys synchronizers synchronously.
keelerm84
added a commit
that referenced
this pull request
Nov 19, 2025
<!-- CURSOR_SUMMARY --> > [!NOTE] > Introduces FDv2 data system configuration and robust synchronizer lifecycle (start/stop), integrates SSE streaming with payload filter, implements an in-memory feature store, and updates tests and contract client accordingly. > > - **FDv2/Data System**: > - Add `Synchronizer.stop()` to interface and implement stop/lifecycle management in `StreamingDataSource` and `PollingDataSource`. > - Enhance `FDv2` to track/stop the active synchronizer safely with locks; ensure threads shut down cleanly. > - Add `datasystem.config` builders (`polling_ds_builder`, `streaming_ds_builder`), expose `fdv1_fallback_synchronizer` in config. > - **Streaming**: > - Switch to `ld_eventsource.SSEClient`; include payload filter in stream URI. > - Handle stream errors by interrupting/closing SSE; stop on unrecoverable errors; ensure closure on exit. > - **Polling**: > - Add stoppable sync loop with `_stop` flag and `stop()` method. > - **Store**: > - Implement thread-safe `InMemoryFeatureStore` with basic CRUD, init, and diagnostics; integrate with `Store`. > - **Contract tests**: > - Support FDv2 `dataSystem` config (initializers/synchronizers, payloadFilter) in `client_entity.py`. > - **Tests**: > - Update streaming synchronizer tests for new SSE client usage and stop/interrupt behavior. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e87daa0. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
keelerm84
added a commit
that referenced
this pull request
Nov 19, 2025
<!-- CURSOR_SUMMARY --> > [!NOTE] > Introduces FDv2 data system configuration and robust synchronizer lifecycle (start/stop), integrates SSE streaming with payload filter, implements an in-memory feature store, and updates tests and contract client accordingly. > > - **FDv2/Data System**: > - Add `Synchronizer.stop()` to interface and implement stop/lifecycle management in `StreamingDataSource` and `PollingDataSource`. > - Enhance `FDv2` to track/stop the active synchronizer safely with locks; ensure threads shut down cleanly. > - Add `datasystem.config` builders (`polling_ds_builder`, `streaming_ds_builder`), expose `fdv1_fallback_synchronizer` in config. > - **Streaming**: > - Switch to `ld_eventsource.SSEClient`; include payload filter in stream URI. > - Handle stream errors by interrupting/closing SSE; stop on unrecoverable errors; ensure closure on exit. > - **Polling**: > - Add stoppable sync loop with `_stop` flag and `stop()` method. > - **Store**: > - Implement thread-safe `InMemoryFeatureStore` with basic CRUD, init, and diagnostics; integrate with `Store`. > - **Contract tests**: > - Support FDv2 `dataSystem` config (initializers/synchronizers, payloadFilter) in `client_entity.py`. > - **Tests**: > - Update streaming synchronizer tests for new SSE client usage and stop/interrupt behavior. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e87daa0. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Introduces FDv2 data system configuration and robust synchronizer lifecycle (start/stop), integrates SSE streaming with payload filter, implements an in-memory feature store, and updates tests and contract client accordingly.
Synchronizer.stop()to interface and implement stop/lifecycle management inStreamingDataSourceandPollingDataSource.FDv2to track/stop the active synchronizer safely with locks; ensure threads shut down cleanly.datasystem.configbuilders (polling_ds_builder,streaming_ds_builder), exposefdv1_fallback_synchronizerin config.ld_eventsource.SSEClient; include payload filter in stream URI._stopflag andstop()method.InMemoryFeatureStorewith basic CRUD, init, and diagnostics; integrate withStore.dataSystemconfig (initializers/synchronizers, payloadFilter) inclient_entity.py.Written by Cursor Bugbot for commit e87daa0. This will update automatically on new commits. Configure here.