-
Notifications
You must be signed in to change notification settings - Fork 55
chore: Create FDv1 datasystem implementation #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create FDv1 datasystem implementation #339
Conversation
| # | ||
| def start(ready_event) | ||
| def start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a little torn on having the ready_event passed in vs returning it. The existing data_source public interface for its start method returns a Concurrent::Event. This means we would either need an interface layer to sync the two events between the data system and the data source, or we would need a breaking change to have the data source interface accept the event vs return it.
The datasystem doesn't use the flagTracker. Instead of creating and being responsible for something it doesn't use, provide access to the broadcaster so the calling code can create a tracker however it needs.
Note
Adds
Impl::DataSystem::FDv1to wrap v1 data flow, extractsImpl::DataSource::NullUpdateProcessor, updates DataSystem interface, and adjusts client and tests accordingly.LaunchDarkly::Impl::DataSystem::FDv1(lib/ldclient-rb/impl/data_system/fdv1.rb) wiring v1 data source/store via broadcasters, status providers, andUpdateSink; implementsstart/stop,store,data_source_status_provider,data_store_status_provider,flag_change_broadcaster,data_availability,target_availability, and processor selection (stream/poll/null/custom), passing diagnostics to streaming.DataSysteminterface (lib/ldclient-rb/impl/data_system.rb):startnow returns aConcurrent::Event(no arg), addflag_change_broadcaster,set_diagnostic_accumulator, expandDataAvailability, and add diagnostic/initializer/synchronizer mixins andUpdateclass.NullUpdateProcessortolib/ldclient-rb/impl/data_source/null_processor.rband update references; remove old inline class fromldclient.rb.NullUpdateProcessorand require new file inlib/ldclient-rb/ldclient.rb.NullUpdateProcessorandFDv1; updateDataSystemcontract specs; extend test helpers (spec/mock_components.rb).Written by Cursor Bugbot for commit 45e8c70. This will update automatically on new commits. Configure here.