chore: Add the FDv2 data system protocol implementation #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
keelerm84
requested changes
Dec 23, 2025
lib/ldclient-rb/impl/data_store/feature_store_client_wrapper.rb
Outdated
Show resolved
Hide resolved
lib/ldclient-rb/config.rb
Outdated
| # @param fdv1_fallback_synchronizer [Proc(Config) => LaunchDarkly::Interfaces::DataSystem::Synchronizer, nil] | ||
| # The (optional) builder proc for FDv1-compatible fallback synchronizer | ||
| # | ||
| def initialize(initializers:, primary_synchronizer:, secondary_synchronizer:, |
Member
There was a problem hiding this comment.
You don't have to change it in this PR, but remember that we want to make synchronizers a list like the initializers.
Co-authored-by: Matthew M. Keeler <mkeeler@launchdarkly.com>
lib/ldclient-rb/impl/data_store/feature_store_client_wrapper.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew M. Keeler <mkeeler@launchdarkly.com>
Co-authored-by: Matthew M. Keeler <mkeeler@launchdarkly.com>
|
|
||
| collections.each do |kind, collection| | ||
| collection.each do |key, item| | ||
| @dependency_tracker.update_dependencies_from(kind, key, item) |
There was a problem hiding this comment.
Dependency tracker receives raw hashes instead of model objects
The Store class passes raw hash data from changes_to_store_data to DependencyTracker.update_dependencies_from, but DependencyTracker.compute_dependencies_from expects FeatureFlag/Segment model objects and uses method-style access like .prerequisites and .rules. Raw hashes don't have these methods, causing a NoMethodError when dependency tracking executes. The data needs to be decoded into model objects before being passed to the dependency tracker, or the dependency tracker needs to use hash-style access ([:prerequisites]).
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces the experimental FDv2 data system and plumbing to acquire, persist, and serve flag data.
DataSystemConfigandLaunchDarkly::DataSystem::ConfigBuilderwith presets (default,streaming,polling,daemon,persistent_store) to compose initializers, synchronizers, and store modeImpl::DataSystem::FDv2) managing initializers/synchronizers, readiness, failover/recovery, diagnostics, and broadcasting status/change eventsinterfaces/data_system.rb,impl/data_system/protocolv2.rb): events, intents, selectors, change sets, payloads, updatesImpl::DataSource::StatusProviderV2,Impl::DataStore::StatusProviderV2) and a feature store client wrapper with availability monitoringdatasystem_configoption; minor model deserialization guard simplificationWritten by Cursor Bugbot for commit 0250999. This will update automatically on new commits. Configure here.