Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

This branch is to add "The Bahamas" queryPreset in presets.go 🇧🇸 #157

Open
steveWDamesJr wants to merge 5 commits into
base: master
Choose a base branch
from
Open

This branch is to add "The Bahamas" queryPreset in presets.go 🇧🇸 #157

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2f9592
Update presets.go with queryPreset The Bahamas
steveWDamesJr Apr 1, 2022
dfaf240
Update presets.go countries
steveWDamesJr Jun 8, 2022
9a45682
Add 'Bahamas' to QueryPreset
steveWDamesJr Jun 27, 2022
a8e4ce6
Update QueryPreset in presets.go
steveWDamesJr Jun 28, 2022
8cca14f
Create more accurate representation of Bahamas Query
steveWDamesJr Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions presets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,9 @@ var PRESETS = map[string]QueryPreset{
"united states": QueryPreset{
include: []string{",+US", "USA", "United+States", "Alabama", ",+AL", "Alaska", ",+AK", "Arizona", ",+AZ", "Arkansas", ",+AR", "California", ",+CA", "Colorado", ",+CO", "Connecticut", ",+CT", "Delaware", ",+DE", "Florida", ",+FL", "Georgia", ",+GA", "Hawaii", ",+HI", "Idaho", ",+ID", "Illinois", ",+IL", "Indiana", ",+IN", "Iowa", ",+IA", "Kansas", ",+KS", "Kentucky", ",+KY", "Louisiana", ",+LA", "Maine", ",+ME", "Maryland", ",+MD", "Massachusetts", ",+MA", "Michigan", ",+MI", "Minnesota", ",+MN", "Mississippi", ",+MS", "Missouri", ",+MO", "Montana", ",+MT", "Nebraska", ",+NE", "Nevada", ",+NV", "New+Hampshire", ",+NH", "New+Jersey", ",+NJ", "New+Mexico", ",+NM", "New+York", ",+NY", "North+Carolina", ",+NC", "North+Dakota", ",+ND", "Ohio", ",+OH", "Oklahoma", ",+OK", "Oregon", ",+OR", "Pennsylvania", ",+PA", "Rhode+Island", ",+RI", "South+Carolina", ",+SC", "South+Dakota", ",+SD", "Tennessee", ",+TN", "Texas", ",+TX", "Utah", ",+UT", "Vermont", ",+VT", "Virginia", ",+VA", "Washington", ",+WA", "West+Virginia", ",+WV", "Wisconsin", ",+WI", "Wyoming", ",+WY", "Los+Angeles", "Chicago", "Houston", "Phoenix", "Philadelphia", "San+Antonio", "San+Diego", "Dallas", "San+Jose", "Austin", "Jacksonville", "Fort+Worth", "Columbus", "Charlotte", "San+Francisco", "Indianapolis", "Seattle", "Denver", "Boston", "El+Paso", "Nashville", "Detroit", "Portland", "Las+Vegas", "Memphis", "Louisville", "Baltimore"},
},
"the bahamas": QueryPreset{
include: []string{"Bahamas"},
Copy link
Author

@steveWDamesJr steveWDamesJr Jun 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋

After viewing the results of the live app, it is determined that the results are not an accurate depiction of users from 'The Bahamas' as users from ie. 'Long Island, NY' (which has the same name as Long Island Bahamas) are being grouped together in 'The Bahamas' Rankings.

This is true of many other Bahamas Island names that share the same name as other states or countries around the world.

To avoid skewed results, I have shortened the QueryPreset to the more unique and inclusive term of 'Bahamas'.

Please update this change in your live sites @ashkulz and @lauripiispanen.

Many thanks 👏

Copy link

@ashkulz ashkulz Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, @steveWDamesJr.

Copy link
Author

@steveWDamesJr steveWDamesJr Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ashkulz 👋 ,

Thank you for your quick action in resolving this issue.

Best,

Steve

},
}

func Preset(name string) QueryPreset {
Expand Down