Skip to content

Comments

chore: weekly lints for 2026-02-23#363

Open
chenson2018 wants to merge 4 commits intoleanprover:mainfrom
chenson2018:weekly-lint-2026-02-23
Open

chore: weekly lints for 2026-02-23#363
chenson2018 wants to merge 4 commits intoleanprover:mainfrom
chenson2018:weekly-lint-2026-02-23

Conversation

@chenson2018
Copy link
Collaborator

@chenson2018 chenson2018 commented Feb 23, 2026

For Cslib.Computability.URM.StandardForm I also added some missing grind annotations, and golfed significantly past what the linter reported. After guiding the case analysis a bit, the performance difference is small.

@chenson2018
Copy link
Collaborator Author

!radar

@leanprover-radar
Copy link

leanprover-radar commented Feb 23, 2026

Benchmark results for fb229ee against e448602 are in! @chenson2018

  • 🟥 build//instructions: +652.9M (+0.04%)

Medium changes (1🟥)

  • 🟥 build/module/Cslib.Computability.URM.StandardForm//instructions: +4.0G (+36.35%)

@chenson2018
Copy link
Collaborator Author

Hmm, that's a bit larger than I was expecting, let me see how much guiding the case analysis helps.

@chenson2018
Copy link
Collaborator Author

!radar

@leanprover-radar
Copy link

leanprover-radar commented Feb 23, 2026

Benchmark results for c341f72 against e448602 are in! @chenson2018

  • 🟥 build//instructions: +1.0G (+0.06%)

Small changes (1🟥)

  • 🟥 build/module/Cslib.Computability.URM.StandardForm//instructions: +1.1G (+10.02%)

@chenson2018
Copy link
Collaborator Author

!radar

@leanprover-radar
Copy link

leanprover-radar commented Feb 23, 2026

Benchmark results for d202d5e against e448602 are in! @chenson2018

  • 🟥 build//instructions: +1.1G (+0.06%)

Small changes (1🟥)

  • 🟥 build/module/Cslib.Computability.URM.StandardForm//instructions: +1.1G (+10.04%)

@chenson2018
Copy link
Collaborator Author

I am now happy with this as a "small change" to performance that preserves more of the structure of the original proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants