chore: weekly lints for 2026-02-23#363
Open
chenson2018 wants to merge 4 commits intoleanprover:mainfrom
Open
Conversation
Collaborator
Author
|
!radar |
|
Benchmark results for fb229ee against e448602 are in! @chenson2018
Medium changes (1🟥)
|
Collaborator
Author
|
Hmm, that's a bit larger than I was expecting, let me see how much guiding the case analysis helps. |
Collaborator
Author
|
!radar |
|
Benchmark results for c341f72 against e448602 are in! @chenson2018
Small changes (1🟥)
|
Collaborator
Author
|
!radar |
|
Benchmark results for d202d5e against e448602 are in! @chenson2018
Small changes (1🟥)
|
Collaborator
Author
|
I am now happy with this as a "small change" to performance that preserves more of the structure of the original proof. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
Cslib.Computability.URM.StandardFormI also added some missinggrindannotations, and golfed significantly past what the linter reported. After guiding the case analysis a bit, the performance difference is small.