-
Notifications
You must be signed in to change notification settings - Fork 269
[Remove Vuetify from Studio] Convert 'Create an account' unit tests to Vue Testing Library #5634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
|
👋 Thanks for contributing! We will assign a reviewer within the next two weeks. In the meantime, please ensure that:
We'll be in touch! 😊 |
|
Some submission-related tests are intentionally skipped due to current Vuetify components (v-select / v-autocomplete) not being reliably testable with userEvent, I’ve added inline notes for re-enabling them after the migration. Could you please confirm if this approach aligns with expectations, or if you’d prefer a different way of handling the skipped workflows? Thanks! |
|
Hello @MisRob, can you please have a look and provide a reviewer for this PR, implementation is complete and If any changes required please let me know. |
ba67625 to
1a27019
Compare
|
Hi @abhiraj75, thanks! - I invited community members to review before we assign a core team member (that may take longer time as mentioned in the bot message) - so let's see if someone will have suggestions :) |
|
Also @abhiraj75 I also wanted to mention that newer community members could join reviews and that this first round of review is meant rather as collaborative experience. If any feedback doesn't feel relevant, you don't need to take it as definitive - please engage together in clarification and discussion. |
|
Thankyou @MisRob , I appreciate the collaborative approach, and I’m happy to discuss/clarify any feedback as it comes up. |
Refactored the accounts/pages/tests/create.spec.js test suite to use Vue Testing Library (VTL) and align tests with real user interactions instead of component internals.
The new tests focus on core user workflows:
Visiting the Create Account page
Interacting with form fields and checkboxes
Submitting the form with missing data
Handling URL-prefilled email values
Tests that depend on Vuetify-specific components (e.g. dropdowns) are explicitly skipped with clear comments, following Testing Library principles and keeping the suite resilient ahead of the planned Vuetify removal.
Manual verification
Ran the updated test suite locally using pnpm test accounts/pages/tests/create.spec.js (from the frontend folder)
Verified all non-skipped tests pass
Confirmed skipped tests are documented and justified
No UI layout or visual changes were made.
References
Closes #5633
Refactors: accounts/pages/tests/create.spec.js
Reviewer guidance
To review:
Navigate to accounts/pages/tests/create.spec.js
Verify tests:
Use @testing-library/vue
Follow Testing Library query priority (roles, labels)
Describe behavior from a user’s point of view
Run:
pnpm test accounts/pages/tests/create.spec.js (from the frontend folder)
Notes for reviewers
Skipped tests are intentional and documented due to known limitations with Vuetify components in VTL
No production code was changed
This PR is scoped strictly to test refactoring, per the issue’s out-of-scope requirements