Skip to content

Fix recent GEGLU changes slowing down inference unet models #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stduhpf wants to merge 1 commit into from
Closed

Fix recent GEGLU changes slowing down inference unet models #1079

stduhpf wants to merge 1 commit into from

Conversation

@stduhpf
Copy link
Contributor

@stduhpf stduhpf commented Dec 12, 2025

Fixes #984

@stduhpf
Copy link
Contributor Author

stduhpf commented Dec 12, 2025 •
edited
Loading

@leejet It looks like ggml_ext_chunk() is a serious bottleneck. Probably because of the repeated use of ggml_permute() and ggml_cont(). Maybe rewriting it to avoid relying on permutations instead of merging this PR would be even better. Let me know if you'd prefer me giving it a shot.

@leejet
Copy link
Owner

leejet commented Dec 12, 2025

Perhaps #1080 is a simpler fix.

@stduhpf stduhpf closed this Dec 12, 2025
@wbruna wbruna mentioned this pull request Dec 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Performance regression

2 participants

@stduhpf @leejet