Open
Conversation
This runs the updated `go fix` from Go 1.26 There are some more fixes once Boulder updates to Go 1.26 - these are just for the current Go 1.25.
aarongable
approved these changes
Feb 20, 2026
Contributor
aarongable
left a comment
There was a problem hiding this comment.
I was planning on waiting until go1.26 to run this tool, but LGTM.
Could you provide more details about exactly what go fix command(s) you ran? Did you limit it to certain analyzers or certain files?
Contributor
Author
|
The invocation was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This runs the updated
go fix ./…from Go 1.26There are some more fixes once Boulder updates to Go 1.26 - these are just for
the current Go 1.25.
Fixes applied: