Draft
Conversation
We'll support the previous DofMap interface for backwards compatibility, but it's not actually needed now.
2966de8 to
dbcf3a3
Compare
Member
Author
|
I swear I did compile that myself before pushing ... but I might have only compiled it in a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't technically a complete solution to #4253, because it still won't let us use different p-refinement settings in the same VariableGroup, but IMHO it's good enough to count as a fix for that issue - it lets us add_variable() with p-refinement disabled, and the DofMap won't automatically group together variables with and without p-refinement, so we can easily have variables with the same order and same family and different p-refinement levels.
I'm starting this PR in draft status because I need to add more tests before we can consider merging it, but it's at least at the point where I want to see if it breaks any of the MOOSE
should_p_refine()test coverage.