Draft
Conversation
With the "local" option added it works for Nemesis too. Hopefully this will let us get add_sides support into Nemesis eventually, but also let me get multi-block-subdomain support into both at once.
These are long enough that they might not be inlined regardless, and this helper class is complicated enough with the declarations alone
Member
Author
|
Consistent failures of I'm glad I decided to check, and horrified that there's a bug here so subtle that it made it through all the libMesh and MOOSE framework tests before finally getting caught in 3 out of ~7000 modules tests... |
Member
Author
|
It's that very first build_subdomain_map refactor that's breaking; I thought I'd figured out why, but my first attempt at a fix didn't help at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping that cleanup of our ExodusII code will make it a little easier to add some new features (and to extend more features to Nemesis) in the near future.
I'm posting to a PR to see if I've accidentally broken any MOOSE tests, but leaving it as "draft" until we've got more-than-just-refactoring work that we'll want to base off of it.