Disable bindgen version comment in generated bindings.rs
#134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With us having CI check that the bindgen generated bindings are up-to-date, we can run into issues where we now see a CI failure just because they released a new patch version and now the generated bindings contain a slightly outdated version string in them. E.g.: --- a/src/bindings.rs +++ b/src/bindings.rs @@ -1,4 +1,4 @@ -/* automatically generated by rust-bindgen 0.72.0 */ +/* automatically generated by rust-bindgen 0.72.1 */ This is annoying and a waste of time to tend to. Really the version string in there doesn't add any value: we basically know the major and minor version of bindgen that we used, because we specified it in our Cargo.toml and the patch level really shouldn't have any relevance. So disable the embedding of this version string into the generate bindings altogether. Signed-off-by: Daniel Müller <deso@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With us having CI check that the bindgen generated bindings are up-to-date, we can run into issues where we now see a CI failure just because they released a new patch version and now the generated bindings contain a slightly outdated version string in them. E.g.:
This is annoying and a waste of time to tend to. Really the version string in there doesn't add any value: we basically know the major and minor version of bindgen that we used, because we specified it in our Cargo.toml and the patch level really shouldn't have any relevance. So disable the embedding of this version string into the generate bindings altogether.