Skip to content

Comments

feat(upnp): add integration tests#6264

Open
ackintosh wants to merge 8 commits intolibp2p:masterfrom
ackintosh:integration-tests-for-upnp
Open

feat(upnp): add integration tests#6264
ackintosh wants to merge 8 commits intolibp2p:masterfrom
ackintosh:integration-tests-for-upnp

Conversation

@ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Feb 4, 2026

Description

  • Add integration tests for the UPnP behaviour using the mock-igd crate
  • Introduce test_mode to enable testing without real UPnP infrastructure

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@ackintosh ackintosh force-pushed the integration-tests-for-upnp branch from 0f4e9c4 to a0ea2f0 Compare February 8, 2026 00:41
@ackintosh ackintosh force-pushed the integration-tests-for-upnp branch from a0ea2f0 to e1bfd65 Compare February 8, 2026 00:48
@ackintosh ackintosh marked this pull request as ready for review February 8, 2026 01:00
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Akihito! Thanks for this, but changing the ci workflow and the Behavior with fields just for test seem like a code smell to me, can we avoid this?
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants