Create default settings file, and ignore used file

[Dubz]

This changes the settings file name, and adds an entry to gitignore to ignore the used file name.

This will avoid any issues pulling updates to a live environment with a modified settings file.

[adolfintel]

That's actually not a bad idea. I'll merge this with the next major release (I need to update the video tutorial)

[Dubz]

That's actually not a bad idea. I'll merge this with the next major release (I need to update the video tutorial)

Sounds good!

You may want to consider merging the ./backend/getIP_ipInfo_apikey.php file with it as well, and any other similar files. I'm sure people run into the same issue if they utilize that too.

[adolfintel]

Yes, I was thinking the same thing

[flying-sausages]

Seeing as there are conflicts here, has this been merged?

[adolfintel]

@flying-sausages No, but this concept will certainly be included in the next release. I was planning it for 2020 but I've had too many things to do so I haven't done any real work on LS in a while.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Dubz]

Any update? 😁

[sstidl]

Any update? 😁

@Dubz Could you review your changes please? You have to rebase your PR on the newdesign branch. A lot has changed there. Maybe your changes are already included.
Thank you!

[Dubz]

Any update? 😁

@Dubz Could you review your changes please? You have to rebase your PR on the newdesign branch. A lot has changed there. Maybe your changes are already included. Thank you!

Doesn't appear as though they are included. The telemetry_settings.php file still exists.

It's very standard to provide an example settings file along with instructions on how users can create their own. Making that file in the repo causes conflict any time anyone goes to update their install as they'll have to recreate that file every single time. It's not good practice to do.

While this PR likely won't fit right with all of the changes, it should provide plenty of example on how this can be achieved.

[sstidl]

I reviewed your changes again and now I understand your intention better.
I don't think it's good practice to let the server use the default config as there are passwords and settings for db in the example config file.
As the preferred way to install the service is via docker image, your additions would interfere.
So I'm sorry to say that we won't add the changes.