fix mipmaps on generated textures in d3d10, d3d11 and d3d12 #18513
+64
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes mipmaps on generated textures
fixes mipmaps on generated textures
same issue as d3d11 and d3d12
hunterk
changed the title
Collaborator
|
Quick d3d11 test looking the same as vulkan now here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In both of these drivers, mipmaps worked for external textures, like LUTs, but were not calculated/generated properly for internally generated textures. This PR fixes that.
Related Issues
should fix this one #16567
Related Pull Requests
none
Reviewers
@bslenul tested a preliminary version of this for me before, so it'd be good to hear from them whether this treats them any better