Skip to content

Fix usage of HAVE_VISIBILITY/DEFAULT_VISIBILITY #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youw merged 3 commits into from
Oct 18, 2025
Merged

Fix usage of HAVE_VISIBILITY/DEFAULT_VISIBILITY #37

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ca012d
Fix usage of HAVE_VISIBILITY/DEFAULT_VISIBILITY
Youw Oct 18, 2025
acba6b2
Merge branch 'main' into fix-visibility
Youw Oct 18, 2025
425d2f2
strict check
Youw Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ function(generate_config_file)

check_struct_has_member("struct timespec" tv_sec time.h HAVE_STRUCT_TIMESPEC)

if(CMAKE_C_COMPILER_ID MATCHES "Clang" OR CMAKE_C_COMPILER_ID STREQUAL "GNU")
check_c_compiler_flag("-fvisibility=hidden" HAVE_VISIBILITY)
else()
set(HAVE_VISIBILITY OFF)
endif()

if(HAVE_VISIBILITY)
set(DEFAULT_VISIBILITY "__attribute__((visibility(\"default\")))")
else()
Expand All @@ -74,10 +80,6 @@ function(generate_config_file)
set(LIBUSB_WINDOWS_HOTPLUG 1)
endif()

if(CMAKE_C_COMPILER_ID MATCHES "Clang" OR CMAKE_C_COMPILER_ID STREQUAL "GNU")
check_c_compiler_flag("-fvisibility=hidden" HAVE_VISIBILITY)
endif()

file(MAKE_DIRECTORY "${LIBUSB_GEN_INCLUDES}")
if(NOT MSVC)
set(_GNU_SOURCE TRUE)
Expand Down
Loading