Do not use buffered writers to write lines to the log file #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @benthecarman as a reviewer! |
Collaborator
benthecarman
left a comment
benthecarman
left a comment
There was a problem hiding this comment.
Every log we write is a new line, if we're doing this, may as well not use a buffer
When tailing the log file, we do not expect any buffering as the lines get written.
tankyleo
force-pushed
the
log-with-linewriter
branch
from
6ce7593 to
5fb1ccb
Compare
tankyleo
changed the title
LineWriter to write logs to the log file
benthecarman
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tailing the log file, we do not expect any buffering as the lines get written.