Require two channel updates #103
Conversation
|
I've assigned @TheBlueMatt as a reviewer! |
src/tracking.rs
Outdated
| if chain_hash == ChainHash::REGTEST { | ||
| // There must be two channel updates (one for each end) | ||
| // to generate a snapshot with information about the channel. | ||
| is_caught_up_with_gossip = new_message_count < 20 && previous_announcement_count > 0 && previous_update_count > 0 && counter.channel_updates > 1; |
There was a problem hiding this comment.
Wait, why are we being more strict on regtest than on mainnet? Presumably if its not ever getting to the finished state on regtest we should be removing conditions not adding ones.
There was a problem hiding this comment.
The problem is that I start RGS, open a channel, RGS receives an announcement with one channel update, it sees that it caught up and generates snapshots, but they are empty because we need two channel updates for one channel to include channel information into snapshots. Empty snapshots are pretty much useless.
Here I want to wait for two channel updates, such that snapshots have information about the channel.
There was a problem hiding this comment.
Ah, okay, that makes sense.
There was a problem hiding this comment.
Should we just do this globally, not only for regtest then?
There was a problem hiding this comment.
Not sure, on mainnet is normal to receive only one update for a channel (if it existed before and just one end got updated).
There was a problem hiding this comment.
We're definitely not done syncing mainnet if the total number of channel updates we've seen is only one :)
There was a problem hiding this comment.
Is counter.channel_updates only increasing? If yes, then I agree, it makes sense for any environment.
There was a problem hiding this comment.
@TheBlueMatt just tell me what you think and I will implement.
There was a problem hiding this comment.
Yes, counter.channel_updates should be strictly increasing forever.
There was a problem hiding this comment.
Ok, I removed the Regtest condition.
In order to generate a snapshot with information about a channel, it needs two channel updates (one for each end).
andrei-21
force-pushed
the
feature/wait-for-two-channel-updates
branch
from
10439b8 to
90e6e4a
Compare
andrei-21
changed the title
3 participants
In order to generate a snapshot with information about a channel, it needs two channel updates (one for each end). The change is for Regtest because usually there are only few channels.