Skip to content

fix: SCID preference for outbound payments on spliced channel #4376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okekefrancis112 wants to merge 3 commits into
base: main
Choose a base branch
from
+658 −161
Open

fix: SCID preference for outbound payments on spliced channel #4376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d09d254
test: pull SCID from channel list instead of route
okekefrancis112 Feb 12, 2026
e10c47c
Prefer outbound SCID alias over real SCID for spliced channels
okekefrancis112 Feb 12, 2026
af604a2
fix: use short_channel_id instead of get_outbound_payment_scid in oni…
okekefrancis112 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lightning/src/ln/channel_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,12 +501,12 @@ impl ChannelDetails {
/// This should be used in [`Route`]s to describe the first hop or in other contexts where
/// we're sending or forwarding a payment outbound over this channel.
///
/// This is either the [`ChannelDetails::short_channel_id`], if set, or the
/// [`ChannelDetails::outbound_scid_alias`]. See those for more information.
/// This is either the [`ChannelDetails::outbound_scid_alias`], if set, or the
/// [`ChannelDetails::short_channel_id`]. See those for more information.
///
/// [`Route`]: crate::routing::router::Route
pub fn get_outbound_payment_scid(&self) -> Option<u64> {
self.short_channel_id.or(self.outbound_scid_alias)
self.outbound_scid_alias.or(self.short_channel_id)
}

/// Gets the funding output for this channel, if available.
Expand Down
Loading