Skip to content

Conversation

@wpaulino
Copy link
Contributor

Should we squash all the rustfmt commits into one to keep the git history tidier?

We have the same error being returned from several `ChannelManager`
message handlers, so we DRY it up. Doing so also lets us get rid of the
inlined `format!` call, which for some reason prevents `rustfmt` from
formatting code around it.
We have the same error being returned from several `ChannelManager` API
methods, so we DRY it up. Doing so also lets us get rid of the inlined
`format!` call, which for some reason prevents `rustfmt` from formatting
code around it.
@wpaulino wpaulino self-assigned this Feb 12, 2026
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Feb 12, 2026

I've assigned @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 52.07756% with 173 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.06%. Comparing base (2647583) to head (fb6d61a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 49.56% 159 Missing and 14 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4412      +/-   ##
==========================================
+ Coverage   86.05%   86.06%   +0.01%     
==========================================
  Files         156      156              
  Lines      103384   103454      +70     
  Branches   103384   103454      +70     
==========================================
+ Hits        88971    89042      +71     
+ Misses      11900    11896       -4     
- Partials     2513     2516       +3     
Flag Coverage Δ
tests 86.06% <52.07%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's random formatting in the first two prefactors which is weird.

@TheBlueMatt TheBlueMatt merged commit 0b45bfd into lightningdevkit:main Feb 12, 2026
16 checks passed
@wpaulino
Copy link
Contributor Author

There's random formatting in the first two prefactors which is weird.

That's because the formatter wasn't actually being applied due to the inlined macro call.

@wpaulino wpaulino deleted the rustfmt-channelmanager-splice-msg-handlers branch February 12, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants