Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Jan 19, 2026

Description

LCORE-1170: Up-to-date-configuration documentation after a2a patch

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1170

Summary by CodeRabbit

  • Documentation
    • Added Azure Entra ID authentication configuration documentation covering tenant ID, client ID, client secret, and scope settings for Microsoft Entra-based authentication.
    • Expanded Model Context Protocol Server configuration documentation with new authorization headers support for custom header mappings and configurable timeout behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

Walkthrough

Documentation schema updates adding AzureEntraIdConfiguration with tenant credentials and expanding ModelContextProtocolServer with authorization headers and timeout fields across HTML and Markdown configuration documentation.

Changes

Cohort / File(s) Summary
Configuration Documentation Updates
docs/config.html, docs/config.md
Added new AzureEntraIdConfiguration section with tenant_id, client_id, client_secret, and scope fields. Introduced azure_entra_id entry to global Configuration. Extended ModelContextProtocolServer with authorization_headers (object for header mappings) and timeout (integer for request timeout) fields. Updated HTML colgroup for layout accommodation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title correctly identifies this as a documentation update for configuration after an a2a patch, which directly matches the changeset adding AzureEntraIdConfiguration and ModelContextProtocolServer fields to docs files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 8d987d0 into lightspeed-core:main Jan 19, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant