Skip to content

Update ticket description format and simplify PR description handling in bump-gitstream-core workflow [skip ci] #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MishaKav merged 1 commit into from
Apr 21, 2025
Merged

Update ticket description format and simplify PR description handling in bump-gitstream-core workflow [skip ci] #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/bump-gitstream-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
required: true
default: 2.1.133
ticket:
description: LINBEE-XXXX ticket number
description: LINBEE-XXXXX ticket number
default: LINBEE-8514
required: false
description:
Expand Down Expand Up @@ -54,11 +54,11 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
Copy link

@jit-ci jit-ci bot Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Static Code Analysis Yaml

Shell Injection In Github Actions

Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".

Severity: HIGH

Learn more about this issue

Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_ignore_type_in_file Ignore any finding of type "Shell Injection in GitHub Actions" in .github/workflows/bump-gitstream-core.yml; future occurrences will also be ignored.
  • #jit_undo_ignore Undo ignore command

Copy link
Collaborator Author

@MishaKav MishaKav Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#jit_ignore_accept

echo -e "Bump \`@linearb/gitstream-core\` to \`${{ env.VERSION }}\`\n\n${{ inputs.description }}" > pr_description.txt
echo -e "${{ inputs.description }}" > pr_description.txt
git config --global user.name 'GitHub Actions Bot'
git config --global user.email 'actions@github.com'
git add package.json package-lock.json dist/index.js
git commit -m "bump `@linearb/gitstream-core` to `${{ env.VERSION }}`" -m "${{ inputs.description }}"
git commit -m "bump `@linearb/gitstream-core` to `${{ env.VERSION }}`"
git push origin HEAD:${{ env.BRANCH_NAME }}
gh pr create \
--base develop \
Expand Down