Skip to content

Add GLib-style validation logic for AVL tree structures #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add GLib-style validation logic for AVL tree structures #112

konard wants to merge 3 commits into from

Conversation

@konard
Copy link
Member

@konard konard commented Sep 14, 2025 •
edited
Loading

Summary

This PR implements validation logic from GNOME/glib/gtree.c for tree structure integrity checks.

Key Features:

  • Balance Factor Validation: Compares calculated vs stored balance factors
  • AVL Property Validation: Ensures balance factors are within [-1, 0, 1] range
  • Height Calculation: Recursive height computation following GLib patterns
  • Structural Integrity: Comprehensive validation of tree relationships
  • Integration: Works seamlessly with existing size validation

Implementation Details:

  • Added GetNodeHeight() method following GLib's g_tree_node_height logic
  • Added ValidateNodeStructure() method following GLib's g_tree_node_check logic
  • Added ValidateTree() method for complete tree validation
  • Integration points in AttachCore and DetachCore operations
  • Conditional compilation with ENABLE_TREE_AUTO_DEBUG_AND_VALIDATION

Testing:

  • Added comprehensive test SizedAndThreadedAVLBalancedTreeValidationTest
  • Tests basic attach/detach operations with automatic validation
  • Validation runs automatically when debug flag is enabled

The validation logic closely follows the GLib implementation patterns and provides robust tree integrity checking for debugging and development purposes.

Fixes #12

🤖 Generated with Claude Code

@konard
Initial commit with task details for issue #12
dd03265 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #12
@konard konard self-assigned this Sep 14, 2025
@konard @claude
Add GLib-style validation logic for AVL tree structures
eb1eb85 
Implements validation logic from GNOME/glib/gtree.c for tree integrity checks including:
- Balance factor validation (comparing calculated vs stored balance)
- AVL property validation (balance factor must be -1, 0, or 1)
- Height calculation for tree nodes
- Recursive validation of subtrees
- Integration with existing size validation

The validation is enabled by ENABLE_TREE_AUTO_DEBUG_AND_VALIDATION and follows the
same patterns as the GLib implementation. Includes comprehensive test coverage.

Fixes issue #12

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Add validation logic from glib/gtree.c Add GLib-style validation logic for AVL tree structures Sep 14, 2025
@konard konard marked this pull request as ready for review September 14, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@konard konard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add validation logic from glib/gtree.c

2 participants

@konard