-
Notifications
You must be signed in to change notification settings - Fork 392
upcoming: [UIE-9327] - Add service URIs to Database summary tab #13261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [UIE-9327] - Add service URIs to Database summary tab #13261
Conversation
packages/manager/src/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummary.tsx
Show resolved
Hide resolved
.../features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryConnectionDetails.style.ts
Show resolved
Hide resolved
...r/src/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryConnectionDetails.tsx
Show resolved
Hide resolved
packages/manager/src/features/Databases/DatabaseDetail/GeneralServiceURI.tsx
Outdated
Show resolved
Hide resolved
...r/src/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryConnectionDetails.tsx
Outdated
Show resolved
Hide resolved
mpolotsk-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested verification steps:
- MySQL Database Summary page shows the service URI under Connection Details.
- PostgreSQL Database Summary page shows the service URI under Connection Details and the PgBouncer section.
packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.tsx
Outdated
Show resolved
Hide resolved
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
| </Typography> | ||
| <ServiceURI database={database} /> | ||
| </Grid> | ||
| )} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may not be necessary, but I'm wondering if it would make sense to add some kind of error state for this field in the event that the connection-pools GET call fails. Currently it just hides the PgBouncer Connection Details field as a whole, but they won't actually see any error messaging until they navigate to the Networking tab.
smans-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great and all my feedback has been addressed! I left a follow up comment on the error handling behavior in the summary tab, as something we might want to consider.
But this looks good to me so I've approved!
Description 📝
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅